[skip changelog] Remove protobuf workaround on AppVeyor #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now switch back to a current version of the protocol since the PR protocolbuffers/protobuf#5044 has been merged to master a released.
|
@rsora the build on AppVeyor looks fine with protobuf v3.9.1 .. what do you think? |
masci
approved these changes
Aug 7, 2019
| @@ -29,7 +29,7 @@ install: | |||
| # protobuf tooling needed at test time. We use a very old version of the compiler | |||
| # because of this: https://github.com/protocolbuffers/protobuf/issues/3957 | |||
There was a problem hiding this comment.
Let's remove this notice now that we can get latest
There was a problem hiding this comment.
Should we get the latest also on the Docker image used for the unix builds on drone.io? Now it's using the v3.8.0.
There was a problem hiding this comment.
yeah let's consolidate versions across different platforms 👍
masci
changed the title
|
I've edited PR title to avoid this to end in the changelog (it doesn't affect users) |
zmoog
pushed a commit
that referenced
this pull request
Aug 9, 2019
Now we can have the same version on both drone.io and AppVeyor, see PR #329 for the details.
zmoog
pushed a commit
that referenced
this pull request
Aug 9, 2019
Now we can have the same version on both drone.io and AppVeyor, see PR #329 for the details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now switch back to a current version of the protocol since the
PR protocolbuffers/protobuf#5044 has been
merged to master a released.